Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the MSRV to v1.67 #299

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Bump the MSRV to v1.67 #299

merged 2 commits into from
Nov 13, 2024

Conversation

Kerollmops
Copy link
Member

To make the #297 CI pass.

@Kerollmops Kerollmops mentioned this pull request Nov 12, 2024
2 tasks
@Dr-Emann
Copy link
Member

Could also consider committing the lock file

@Kerollmops Kerollmops changed the title Bump the MSRV to v1.67 Bump the MSRV to v1.67 and track the lock file Nov 12, 2024
@Kerollmops Kerollmops changed the title Bump the MSRV to v1.67 and track the lock file Bump the MSRV to v1.67 Nov 12, 2024
@Kerollmops Kerollmops merged commit dd8bc5a into main Nov 13, 2024
4 checks passed
@Kerollmops Kerollmops deleted the bump-msrv-1-67 branch November 13, 2024 08:53
@Kerollmops
Copy link
Member Author

Could also consider committing the lock file

I prefer to have errors so that I know when I need to upgrade the dependencies. I mean, there is maybe a better way to know that 🤔

@Dr-Emann
Copy link
Member

Can have a CI task that tries cargo update first, but isn't fatal if it fails, something like: https://github.com/RoaringBitmap/croaring-rs/blob/96fa65071c2fdbc6ab285613f7c14802cb104c7d/.github/workflows/rust.yml#L64-L66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants